No capture actions can be triggered if screenshot chrome extension appears only in Tools menu

Question

Plugin version: FireShot for Firefox v0.98.70
OS type and version: MS Windows 7 Enterprise SP1 Ultimate, English, 64-bit
Version of browser: Firefox 38.0.1
Webpage URL causing this problem: any
Steps to reproduce the bug:

1. Configure the chrome extension to only appear in the Tools menu:
FireShot > Preferences > General > Integrate into: [ ] Context menu [ ] Status Bar [V] Tools menu [ ] Navigation panel
2. Go to any web page and initiate screenshot for any Capture action via the Tools menu
For example, Tools > FireShot > Capture Visible area and ... > Save...
-> Nothing happens (in particular, no file chooser dialog opens)
-> The Browser Console shows a JavaScript Error:
TypeError: Argument 1 of Document.createNodeIterator is not an object. fsoverlay.js:1726:22
3. After integrating into the [V] Navigation panel, capture (both via the Navigation panel and the Tools menu) works again.

I can reproduce this on multiple systems and browsers.

It seems like your implementation does not account for the fact that the DOM menu elements you intend to toggle are not necessarily there, and that UI wiring error then blocks the entire capture process.

Accepted Answer

Good catch! Thank you!

Posted: 15 May 2015 10:12
	Registered User Currently Offline	Posts: 1 Join Date: May 2015
Plugin version: FireShot for Firefox v0.98.70 OS type and version: MS Windows 7 Enterprise SP1 Ultimate, English, 64-bit Version of browser: Firefox 38.0.1 Webpage URL causing this problem: any Steps to reproduce the bug: 1. Configure the chrome extension to only appear in the Tools menu: FireShot > Preferences > General > Integrate into: [ ] Context menu [ ] Status Bar [V] Tools menu [ ] Navigation panel 2. Go to any web page and initiate screenshot for any Capture action via the Tools menu For example, Tools > FireShot > Capture Visible area and ... > Save... -> Nothing happens (in particular, no file chooser dialog opens) -> The Browser Console shows a JavaScript Error: TypeError: Argument 1 of Document.createNodeIterator is not an object. fsoverlay.js:1726:22 3. After integrating into the [V] Navigation panel, capture (both via the Navigation panel and the Tools menu) works again. I can reproduce this on multiple systems and browsers. It seems like your implementation does not account for the fact that the DOM menu elements you intend to toggle are not necessarily there, and that UI wiring error then blocks the entire capture process.

Posted: 18 May 2015 11:36
	Administrator Currently Offline	Posts: 4268 Join Date: Jan 2007
Good catch! Thank you! __________________ FireShot Pro Pro Full Webpage Screenshots will be moving to a subscription model soon! There's a last chance to purchase a Lifetime License and get a 33% discount! - https://getfireshot.com/buy.php

Recent topics	Replies	Views	Last Poster
Support Mac	6	1022
FireShot Icon Doesn't Display In Toolbar - FireFox 37.0.2	4	4325
Fireshot (Chrome/OSX) captures scrollbar	0	3135
Screencast recording?	5	3371
Hide/Suppress floating overlay menu pane when printing	3	3280
Cannot save web page to PDF	7	7359
Not able to save files into Dropbox with Cloudfogger	2	2973
Pop-up ads	4	3051
File Name Specificaiton Capability Needs to Come Back to the Program to Give Options.	7	2967
How do I move to FS Pro license to my new computer	1	1004